docker_container: add platform parameter #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
felixfontein
force-pushed
the
docker_container-platform
branch
from
caa5bf5 to
f39e2d0
Compare
felixfontein
force-pushed
the
docker_container-platform
branch
from
f39e2d0 to
23ba177
Compare
felixfontein
changed the title
|
ready_for_review |
briantist
approved these changes
Jul 15, 2022
|
@briantist thanks for this one as well!!! |
This was referenced Aug 12, 2022
ghost
mentioned this pull request
1 task
1 task
This was referenced Aug 12, 2022
1 task
1 task
This was referenced Sep 25, 2022
1 task
This was referenced Oct 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently includes #422. Will rebase once that's merged.Fixes #123.
One problem here is idempotency. For example, for the
hello-world:latestimage, starting a container withlinux/amd64orlinux/386only reports platformlinux. One could work around this by looking at theOs/Arch/Varfields of the image, but these do not always coincide with the values that were used when pulling or creating the container. (I noticed that the variant for ARM can differ in my experiments.)ISSUE TYPE
COMPONENT NAME
docker_container